chore: replace custom sort postprocess with keep_model_order config#734
Merged
chore: replace custom sort postprocess with keep_model_order config#734
Conversation
datamodel-code-generator's built-in --keep-model-order already performs topological sort with class-name ordering, producing identical output to our custom alphabetizer. Enabling it in pyproject.toml lets us drop the sort_classes postprocess step and its tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
github-actions
bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 95.38% 95.42% +0.03%
==========================================
Files 45 45
Lines 5115 5115
==========================================
+ Hits 4879 4881 +2
+ Misses 236 234 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keep_model_order = truein[tool.datamodel-codegen]config.sort_classespostprocess step and its 16 unit tests.src/apify_client/_models.py— zero diff vs. the previous custom-sort output.datamodel-code-generator's built-in--keep-model-orderalready does a topological sort with class-name ordering, which is equivalent to what our custom script was doing. Discussed with the maintainer in koxudaxi/datamodel-code-generator#3087.