Skip to content

refactor: consolidate StorageOwnership to the generated StrEnum#735

Merged
vdusek merged 1 commit intomasterfrom
refactor/consolidate-storage-ownership
Apr 17, 2026
Merged

refactor: consolidate StorageOwnership to the generated StrEnum#735
vdusek merged 1 commit intomasterfrom
refactor/consolidate-storage-ownership

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented Apr 17, 2026

Summary

  • Removes the duplicate StorageOwnership Literal from _types.py.
  • Reuses the auto-generated StorageOwnership StrEnum from _models.py in the dataset, key-value store, and request queue collection clients.
  • Updates the unit tests to pass enum members (StorageOwnership.OWNED_BY_ME / SHARED_WITH_ME) instead of raw strings.

Closes #700.

Drop the duplicate StorageOwnership Literal from _types.py and reuse the
auto-generated StrEnum from _models.py in dataset, key-value store, and
request queue collection clients.
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Apr 17, 2026
@vdusek vdusek self-assigned this Apr 17, 2026
@vdusek vdusek requested a review from Pijukatel April 17, 2026 08:45
@github-actions github-actions bot added this to the 138th sprint - Tooling team milestone Apr 17, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Apr 17, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (3d4ce3f) to head (4adeec7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   95.26%   95.61%   +0.35%     
==========================================
  Files          45       45              
  Lines        5115     5113       -2     
==========================================
+ Hits         4873     4889      +16     
+ Misses        242      224      -18     
Flag Coverage Δ
integration 95.61% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit 1097e5f into master Apr 17, 2026
26 checks passed
@vdusek vdusek deleted the refactor/consolidate-storage-ownership branch April 17, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding snake_case to camelCase conversion for Literal parameter values

3 participants