Conversation
Copy the caller-provided `headers` up-front so `Content-Type`/`Content-Encoding` additions do not leak back into a shared dict reused across HTTP calls. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 95.36% 95.29% -0.08%
==========================================
Files 45 45
Lines 5118 5117 -1
==========================================
- Hits 4881 4876 -5
- Misses 237 241 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_prepare_request_callinHttpClientBasewas mutating the caller'sheadersdict in place — theif not headers: headers = {}guard only allocated a new dict when the caller passedNone/empty, so a non-empty caller-owned dict was mutated directly. Users of the documented customHttpClient/HttpClientAsyncextension points that reuse a shared headers dict acrosscall()invocations would see staleContent-Type/Content-Encodingheaders leak into subsequent requests (e.g. a bodylessGETcarryingContent-Encoding: gzipfrom a priorPOST).Fix: copy up-front with
headers = dict(headers) if headers else {}. Added a regression test covering the aliased-dict case.