ci: add missing top level contents permission#779
Merged
Conversation
`manual_release_docs.yaml` and `on_issue.yaml` were missing a top-level `permissions: contents: read` block — bringing them in line with the other workflows in this repo and with apify-sdk-python / crawlee-python.
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
==========================================
- Coverage 97.56% 97.50% -0.07%
==========================================
Files 47 47
Lines 4725 4725
==========================================
- Hits 4610 4607 -3
- Misses 115 118 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
vdusek
changed the title
janbuchar
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two workflows in this repo were missing a top-level
permissions: contents: readblock:.github/workflows/manual_release_docs.yaml.github/workflows/on_issue.yamlThe other workflows here, as well as the equivalents in
apify-sdk-pythonandcrawlee-python, all set this default at the file level. This applies the principle of least privilege: jobs that need to escalate (e.g.contents: write,pages: write,issues: write) still do so via job-level overrides.Changes
permissions: contents: readat the top level of both workflow files.