refactor!: remove deprecated APIs#799
Merged
Merged
Conversation
Drop `DatasetClient.download_items()`, the `max_unprocessed_requests_retries` and `min_delay_between_unprocessed_requests_retries` arguments of `batch_add_requests`, and the `exclusive_start_id` argument of `list_requests`. They have been deprecated for a long time and v3 is the right moment to remove them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 94.23% 94.36% +0.13%
==========================================
Files 49 49
Lines 4941 4920 -21
==========================================
- Hits 4656 4643 -13
+ Misses 285 277 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janbuchar
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes deprecated APIs as part of the v3 major release:
DatasetClient.download_items()— deprecated alias ofget_items_as_bytes().max_unprocessed_requests_retriesandmin_delay_between_unprocessed_requests_retriesarguments ofbatch_add_requests(sync + async). The docstrings already said "Will be removed in next major release."exclusive_start_idargument oflist_requests(sync + async) — replaced bycursor.Also drops the now-unused
import warningsfrom both resource client modules and the associated unit tests for the removedcursor/exclusive_start_idmutex check.