Skip to content

refactor!: remove deprecated APIs#799

Merged
vdusek merged 2 commits into
masterfrom
refactor/remove-deprecated-api
May 19, 2026
Merged

refactor!: remove deprecated APIs#799
vdusek merged 2 commits into
masterfrom
refactor/remove-deprecated-api

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented May 19, 2026

Summary

Removes deprecated APIs as part of the v3 major release:

  • DatasetClient.download_items() — deprecated alias of get_items_as_bytes().
  • max_unprocessed_requests_retries and min_delay_between_unprocessed_requests_retries arguments of batch_add_requests (sync + async). The docstrings already said "Will be removed in next major release."
  • exclusive_start_id argument of list_requests (sync + async) — replaced by cursor.

Also drops the now-unused import warnings from both resource client modules and the associated unit tests for the removed cursor/exclusive_start_id mutex check.

Drop `DatasetClient.download_items()`, the `max_unprocessed_requests_retries` and `min_delay_between_unprocessed_requests_retries` arguments of `batch_add_requests`, and the `exclusive_start_id` argument of `list_requests`. They have been deprecated for a long time and v3 is the right moment to remove them.
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels May 19, 2026
@vdusek vdusek self-assigned this May 19, 2026
@vdusek vdusek requested a review from janbuchar May 19, 2026 07:33
@github-actions github-actions Bot added this to the 141st sprint - Tooling team milestone May 19, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.36%. Comparing base (7a579bf) to head (b3901cd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
+ Coverage   94.23%   94.36%   +0.13%     
==========================================
  Files          49       49              
  Lines        4941     4920      -21     
==========================================
- Hits         4656     4643      -13     
+ Misses        285      277       -8     
Flag Coverage Δ
integration 90.38% <ø> (+0.04%) ⬆️
unit 82.96% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit 6e5df35 into master May 19, 2026
27 checks passed
@vdusek vdusek deleted the refactor/remove-deprecated-api branch May 19, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants