ci: avoid branch clash in regenerate-models workflow#812
Open
vdusek wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #812 +/- ##
==========================================
+ Coverage 94.50% 94.52% +0.02%
==========================================
Files 48 48
Lines 4916 4916
==========================================
+ Hits 4646 4647 +1
+ Misses 270 269 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
It works now: #813 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the branch-clash bug in
.github/workflows/manual_regenerate_models.yamlthat was flagged as a follow-up in #809. The recent manual run (failing CI) failed at theCommit model changesstep with:Cause
The local
git switch -c "$BRANCH"step pre-created the branch unconditionally.apify/actions/signed-commit@v1.0.0withcreate-branch: 'true'then rangit fetch --depth=1 origin "$BRANCH:refs/heads/$BRANCH", which refuses to fetch into a checked-out branch.Fix
create-branch: false.create-branch: true.The
create_branchdecision is exported from the renamedSet up branchstep and consumed by the signed-commit step.