-
Notifications
You must be signed in to change notification settings - Fork 133
Closed
Labels
adhocAd-hoc unplanned task added during the sprint.Ad-hoc unplanned task added during the sprint.bugSomething isn't working.Something isn't working.low priorityLow priority issues to be done eventually.Low priority issues to be done eventually.t-core-servicesIssues with this label are in the ownership of the core services team.Issues with this label are in the ownership of the core services team.validatedIssues that are resolved and their solutions fulfill the acceptance criteria.Issues that are resolved and their solutions fulfill the acceptance criteria.
Description
Two webhook dispatch endpoints have operationId values that collide when normalized by code generators:
- Line 11635:
/v2/webhooks/{webhookId}/dispatches-operationId: webhook_dispatches_get - Line 11674:
/v2/webhook-dispatches-operationId: webhookDispatches_get
Both IDs normalize to the same identifier (ApiWebhookDispatchesGetRequest) in Go when using openapi-generator, causing build failures. This prevents successful client generation for languages with strict naming conventions.
Proposed solution:
- Rename operationId for
/v2/webhooks/{webhookId}/dispatchestooperationId: webhook_webhookDispatches_get - Keep the same operationId for
/v2/webhook-dispatches-operationId: webhookDispatches_get
The API already uses this pattern for nested resources:
act_runs_getfor/v2/acts/{actId}/runsactorTask_runs_getfor/v2/actor-tasks/{actorTaskId}/runs
Ref:
Metadata
Metadata
Assignees
Labels
adhocAd-hoc unplanned task added during the sprint.Ad-hoc unplanned task added during the sprint.bugSomething isn't working.Something isn't working.low priorityLow priority issues to be done eventually.Low priority issues to be done eventually.t-core-servicesIssues with this label are in the ownership of the core services team.Issues with this label are in the ownership of the core services team.validatedIssues that are resolved and their solutions fulfill the acceptance criteria.Issues that are resolved and their solutions fulfill the acceptance criteria.