fix: rewrite nginx config to support production GH pages URLs #2010
Conversation
github-actions
bot
added
the
t-tooling
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on October 24
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review or bugbot run to trigger another review on this PR
| proxy_pass $docs_upstream; | ||
| proxy_hide_header Content-Type; | ||
| add_header Content-Type "text/markdown; charset=utf-8" always; | ||
| proxy_redirect https://apify.github.io/ https://apify.github.io/apify-docs/; |
There was a problem hiding this comment.
Bug: Markdown Path Handling and Proxy Redirect Issues
The location / block's new rewrite rule ^(/[^./]+)/*$ is too restrictive. Its [^./] character class excludes slashes, breaking markdown content-type handling for multi-level paths. Separately, proxy_redirect rules are configured backwards, rewriting https://apify.github.io/ to https://apify.github.io/apify-docs/ instead of the client-facing domain, incorrectly adding the /apify-docs/ path.
| proxy_pass $docs_upstream/llms-full.txt; | ||
| proxy_hide_header Content-Type; | ||
| add_header Content-Type "text/markdown; charset=utf-8" always; | ||
| proxy_redirect https://apify.github.io/ https://apify.github.io/apify-docs/; |
There was a problem hiding this comment.
Bug: Nginx Proxy Configuration Issues
The proxy_pass directive uses invalid syntax when $docs_upstream resolves to an upstream name, as Nginx doesn't allow paths appended directly. Separately, proxy_redirect in several location blocks redirects between GitHub URLs instead of rewriting upstream GitHub URLs to the public domain, potentially exposing internal URLs.
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
No description provided.