fix: Output schema (fix copy-paste mistakes) #2034
Conversation
…ainerRunUrl (I guess it is a correct variable)
jirispilka
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review or bugbot run to trigger another review on this PR
| "type": "string", | ||
| "title": "Chat client", | ||
| "template": "{{run.containerUrl}}" | ||
| "template": "{{run.containerRunUrl}}" |
There was a problem hiding this comment.
Bug: Template Variable References Incorrect Object
The template variable {{run.containerRunUrl}} references an incorrect object. Documentation shows {{links.containerRunUrl}} for container URLs, and the run object only contains defaultDatasetId and defaultKeyValueStoreId. This could prevent the template from resolving as expected.
There was a problem hiding this comment.
ops, now looking at it again, I'm not sure what is the correct property, @gippy please correct me here
There was a problem hiding this comment.
You can use either run.containerUrl or links.containerRunUrl.
Both are mentioned in the docs and I think it's confusing, we should unify it.
The links.containerRunUrl is mentioned in the available variables here which is what Cursor picked up here I think.
The run.containerUrl is on the other hand mentioned in the example here
There was a problem hiding this comment.
Mulled it over a little bit. I think best option is to use run.containerUrl here, remove the links.containerRunUrl from the available template variables section and add the run.containerUrl there instead.
There was a problem hiding this comment.
Thank you, fixed
|
Preview for this PR was built for commit |
…ks.containerRunUrl` with `run.containerUrl`
|
Preview for this PR was built for commit |
fix: Output schema (fix copy-paste mistakes) and
containerUrl to containerRunUrl (I guess it is the correct variable)Edit: Replace:
lnkis.containerRunUrlwithrun.containerUrlclose: #2033