Skip to content

Conversation

@birosrichard
Copy link
Contributor

@birosrichard birosrichard commented Nov 5, 2025

This PR enables the LLM's dropdown on all academy pages.


Note

Adds /academy to the LLMButtons allowed paths so the dropdown appears on academy pages.

Written by Cursor Bugbot for commit 5385014. Configure here.

@birosrichard birosrichard added the t-web Issues with this label are in the ownership of the web team. label Nov 5, 2025
@github-actions github-actions bot added this to the 127th sprint - Web team milestone Nov 5, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 5385014 and is ready at https://pr-2069.preview.docs.apify.com!

@patrikbraborec
Copy link
Contributor

@TC-MO - will it work correctly with titles in the academy?

@TC-MO
Copy link
Contributor

TC-MO commented Nov 6, 2025

It should, I merged this PR yesterday #2056 removing H1's

@birosrichard birosrichard requested a review from TC-MO November 6, 2025 08:31
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I clicked through random Academy pages, on each subsection (Courses, Tutorials, Glossary), and haven't seen anything out of the ordinary that we do not see already in Platform docs.

The annoying thing is is sometimes the buttons fall below the title like so

Image

But my assumption is this is has to do with the length of the title and there is little we can do about it right?

@birosrichard
Copy link
Contributor Author

LGTM, I clicked through random Academy pages, on each subsection (Courses, Tutorials, Glossary), and haven't seen anything out of the ordinary that we do not see already in Platform docs.

The annoying thing is is sometimes the buttons fall below the title like so

Image But my assumption is this is has to do with the length of the title and there is little we can do about it right?

Yeah, it's because of the length of the title. But we can wrap the h1 like so, I guess. Shouldn't break anything
image

@TC-MO
Copy link
Contributor

TC-MO commented Nov 6, 2025

I don't have that much of an opinion on wrapping tbh, perhaps we could have someone from design chime in 🤔 ?

Other than that I can (later in a separate PR, as to not block this one) go through the titles and see if there is some room for trimming their length

@birosrichard
Copy link
Contributor Author

I don't have that much of an opinion on wrapping tbh, perhaps we could have someone from design chime in 🤔 ?

Other than that, I can (later in a separate PR, as to not block this one) go through the titles and see if there is some room for trimming their length

I agree, perhaps @hanatsai can give her opinion on the title wrapping. But let's not block this PR

@TC-MO
Copy link
Contributor

TC-MO commented Nov 6, 2025

Yup I concur, from my side all good, we can address both length & wrapping in separate PR's

Copy link
Contributor

@webrdaniel webrdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@birosrichard birosrichard merged commit 5eccefe into master Nov 6, 2025
12 of 13 checks passed
@birosrichard birosrichard deleted the feat/add-llms-dropdown-to-academy-pages branch November 6, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-web Issues with this label are in the ownership of the web team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants