-
Notifications
You must be signed in to change notification settings - Fork 135
feat: allow LLMs dropdown in academy pages #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview for this PR was built for commit |
|
@TC-MO - will it work correctly with titles in the academy? |
|
It should, I merged this PR yesterday #2056 removing H1's |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I clicked through random Academy pages, on each subsection (Courses, Tutorials, Glossary), and haven't seen anything out of the ordinary that we do not see already in Platform docs.
The annoying thing is is sometimes the buttons fall below the title like so
But my assumption is this is has to do with the length of the title and there is little we can do about it right?
|
I don't have that much of an opinion on wrapping tbh, perhaps we could have someone from design chime in 🤔 ? Other than that I can (later in a separate PR, as to not block this one) go through the titles and see if there is some room for trimming their length |
I agree, perhaps @hanatsai can give her opinion on the title wrapping. But let's not block this PR |
|
Yup I concur, from my side all good, we can address both length & wrapping in separate PR's |
webrdaniel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍


This PR enables the LLM's dropdown on all academy pages.
Note
Adds
/academyto the LLMButtons allowed paths so the dropdown appears on academy pages.Written by Cursor Bugbot for commit 5385014. Configure here.