-
Notifications
You must be signed in to change notification settings - Fork 141
chore(ci): add repository entry to theme package.json
#2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.jsonrepository entry to theme package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 24
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review or bugbot run to trigger another review on this PR
| "repository": { | ||
| "type": "git", | ||
| "url": "git@github.com:apify/apify-docs.git" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Repository URL Mismatch Breaks Provenance
The repository.url uses SSH format (git@github.com:) instead of HTTPS format (git+https://github.com/). This is inconsistent with the root package.json which uses HTTPS format, and may prevent npm provenance generation from working correctly, which is the stated purpose of adding this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He ain't lying, I guess we can play it safe @barjin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm will normalize it, but sure 👍
|
Preview for this PR was built for commit |
janbuchar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Preview for this PR was built for commit |
Fixes publishing of the
docs-themepackage by adding therepositoryfield to itspackage.json(required for provenance generation).Note
Add
repositoryfield toapify-docs-theme/package.jsonand update lockfile version to 1.0.223.repositoryblock toapify-docs-theme/package.json.@apify/docs-themeversion inpackage-lock.jsonto1.0.223.Written by Cursor Bugbot for commit e4ecd7c. Configure here.