Skip to content

chore(ci): add repository entry to theme package.json #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 13, 2025
Merged

chore(ci): add repository entry to theme package.json #2087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc8fe23
chore(theme): enable OIDC-based publishing to npm
barjin Nov 12, 2025
f8baabd
chore: set correct permissions
barjin Nov 12, 2025
e80e920
chore: apply suggestions
barjin Nov 13, 2025
da65d3e
Merge branch 'master' into chore/oidc-theme-publishing
barjin Nov 13, 2025
e4ecd7c
chore(ci): add `repository` entry to theme `package.json`
barjin Nov 13, 2025
5279ca8
chore: use `https` format for `repository` url
barjin Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apify-docs-theme/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
"types",
"static"
],
"repository": {
"type": "git",
"url": "git+https://github.com/apify/apify-docs.git"
},
Copy link

@cursor cursor bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Repository URL Mismatch Breaks Provenance

The repository.url uses SSH format (git@github.com:) instead of HTTPS format (git+https://github.com/). This is inconsistent with the root package.json which uses HTTPS format, and may prevent npm provenance generation from working correctly, which is the stated purpose of adding this field.

Fix in Cursor Fix in Web

Copy link
Contributor

@janbuchar janbuchar Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He ain't lying, I guess we can play it safe @barjin?

Copy link
Member Author

@barjin barjin Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm will normalize it, but sure 👍

"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"build": "echo 'Building @apify/docs-theme!'"
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.