Skip to content

ci: Add Github Actions lint check#2196

Merged
vdusek merged 3 commits intomasterfrom
add-github-actions-lint-check
Jan 21, 2026
Merged

ci: Add Github Actions lint check#2196
vdusek merged 3 commits intomasterfrom
add-github-actions-lint-check

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented Jan 21, 2026

We already use this in the tooling repositories and in apify/workflows, and I find it pretty useful in all repositories that define GitHub Actions, as it helps reduce the risk of merging invalid workflows.


Note

Introduces automated linting for GitHub Actions workflows to catch invalid configurations early.

  • Adds /.github/workflows/actions-checks.yaml defining actions_lint_check
  • Triggers on pull_request and push to master
  • Runs on ubuntu-latest; steps: actions/checkout@v6 then rhysd/actionlint@v1.7.10

Written by Cursor Bugbot for commit 580beb6. Configure here.

@vdusek vdusek added this to the 132nd sprint - Tooling team milestone Jan 21, 2026
@vdusek vdusek self-assigned this Jan 21, 2026
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jan 21, 2026
@vdusek vdusek requested a review from janbuchar January 21, 2026 12:43
@apify-service-account
Copy link
Copy Markdown

Preview for this PR was built for commit 580beb6c and is ready at https://pr-2196.preview.docs.apify.com!

@vdusek
Copy link
Copy Markdown
Contributor Author

vdusek commented Jan 21, 2026

I had to add some quoting to the Bash scripts, and remove invalid argument passing (always-auth: 'true'), but it should be OK.

@apify-service-account
Copy link
Copy Markdown

Preview for this PR was built for commit d96e1d12 and is ready at https://pr-2196.preview.docs.apify.com!

Comment thread .github/workflows/publish-to-npm.yaml Outdated
Comment on lines +83 to +84
PACKAGE_NAME=$(jq -r .name <(echo "$PACKAGE_JSON"));
PACKAGE_VER=$(jq -r .version <(echo "$PACKAGE_JSON"));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're touching this, I'd much rather just cat the package.json twice than store it in a variable

@vdusek vdusek force-pushed the add-github-actions-lint-check branch from d96e1d1 to c03e195 Compare January 21, 2026 15:12
@apify-service-account
Copy link
Copy Markdown

Preview for this PR was built for commit c03e195 and is ready at https://pr-2196.preview.docs.apify.com!

@vdusek vdusek merged commit 2d88d90 into master Jan 21, 2026
13 checks passed
@vdusek vdusek deleted the add-github-actions-lint-check branch January 21, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants