Merged
Conversation
|
Preview for this PR was built for commit |
Contributor
Author
|
I had to add some quoting to the Bash scripts, and remove invalid argument passing ( |
|
Preview for this PR was built for commit |
janbuchar
approved these changes
Jan 21, 2026
Comment on lines
+83
to
+84
| PACKAGE_NAME=$(jq -r .name <(echo "$PACKAGE_JSON")); | ||
| PACKAGE_VER=$(jq -r .version <(echo "$PACKAGE_JSON")); |
Contributor
There was a problem hiding this comment.
While we're touching this, I'd much rather just cat the package.json twice than store it in a variable
d96e1d1 to
c03e195
Compare
|
Preview for this PR was built for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already use this in the tooling repositories and in
apify/workflows, and I find it pretty useful in all repositories that define GitHub Actions, as it helps reduce the risk of merging invalid workflows.Note
Introduces automated linting for GitHub Actions workflows to catch invalid configurations early.
/.github/workflows/actions-checks.yamldefiningactions_lint_checkpull_requestandpushtomasterubuntu-latest; steps:actions/checkout@v6thenrhysd/actionlint@v1.7.10Written by Cursor Bugbot for commit 580beb6. Configure here.