fix(nginx): use rewrite instead of return for trailing slash redirect#2226
Merged
fix(nginx): use rewrite instead of return for trailing slash redirect#2226
Conversation
Changes the trailing slash redirect from using `return` with location regex to using `rewrite` directive inside the location block. Also removes quotes from the regex pattern to match the style of other regex locations in the config. This should fix the issue where the previous approach wasn't working. Slack thread: https://apify.slack.com/archives/C0L33UM7Z/p1770281199186039 https://claude.ai/code/session_01GqcrG6JU9Y1YaSA5ns87Yz
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 24. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
github-actions
Bot
added
the
t-tooling
|
Preview for this PR was built for commit |
Member
Author
|
Testing in production ™️ 😭 Third time's the charm? |
barjin
approved these changes
Feb 5, 2026
Member
|
Just fyi this didn't fix it (the behaviour is the same as before all these changes, i.e., trailing slashes still return 404s), I don't see any other issues, so not reverting for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the trailing slash redirect from using
returnwith location regex to usingrewritedirective inside the location block. Also removes quotes from the regex pattern to match the style of other regex locations in the config.This should fix the issue where the previous approach wasn't working.
Slack thread: https://apify.slack.com/archives/C0L33UM7Z/p1770281199186039
https://claude.ai/code/session_01GqcrG6JU9Y1YaSA5ns87Yz