Skip to content

docs(openapi): Remove uri format where not enforced by API#2423

Merged
Pijukatel merged 2 commits intomasterfrom
remove-uri-format-where-not-enforced-by-api
Apr 13, 2026
Merged

docs(openapi): Remove uri format where not enforced by API#2423
Pijukatel merged 2 commits intomasterfrom
remove-uri-format-where-not-enforced-by-api

Conversation

@Pijukatel
Copy link
Copy Markdown
Contributor

@Pijukatel Pijukatel commented Apr 13, 2026

  • Remove uri format where not enforced by API:

    • RequestBase.loadedUrl
  • Remove unnecessary properties from UserData

  • Format uri left for following:

    • Webhook.yaml, WebhookUpdate.yaml, WebhookShort.yaml → requestUrl: regex + runtime validation (WEBHOOK_REQUEST_URL_REGEXP + new URL())
    • Profile.yaml → websiteUrl: HTTP_URL_REGEX validation
    • Profile.yaml → pictureUrl: runtime S3 URL check
    • All output-only fields (consoleUrl, keysPublicUrl, itemsPublicUrl, containerUrl, recordPublicUrl, standbyUrl,
      StoreListActor.pictureUrl/userPictureUrl/url): generated by the API itself, always valid URIs

Follow-up for: #2403 (comment)

Partially implements: #2286

@github-actions github-actions bot added this to the 138th sprint - Tooling team milestone Apr 13, 2026
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 13, 2026
@Pijukatel Pijukatel changed the title Remove uri format where not enforced by API docs(openapi): Remove uri format where not enforced by API Apr 13, 2026
@Pijukatel Pijukatel requested a review from vdusek April 13, 2026 12:19
@apify-service-account
Copy link
Copy Markdown

Preview for this PR was built for commit 683050c and is ready at https://pr-2423.preview.docs.apify.com!

@apify-service-account
Copy link
Copy Markdown

A PR to update the Python client models has been created: apify/apify-client-python#720

This was automatically triggered by OpenAPI specification changes in this PR.

@Pijukatel Pijukatel marked this pull request as ready for review April 13, 2026 12:23
Copy link
Copy Markdown
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Copy Markdown
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these properties even coming from? We don

@apify-service-account
Copy link
Copy Markdown

Preview for this PR was built for commit 8e6f243d and is ready at https://pr-2423.preview.docs.apify.com!

@apify-service-account
Copy link
Copy Markdown

The Python client model PR has been updated with the latest OpenAPI spec changes: apify/apify-client-python#720

@Pijukatel Pijukatel merged commit 991c3c6 into master Apr 13, 2026
16 checks passed
@Pijukatel Pijukatel deleted the remove-uri-format-where-not-enforced-by-api branch April 13, 2026 14:45
Pijukatel pushed a commit to apify/apify-client-python that referenced this pull request Apr 13, 2026
This PR updates the auto-generated Pydantic models based on OpenAPI
specification changes in [apify-docs PR
#2423](apify/apify-docs#2423).

---------

Co-authored-by: apify-service-account <apify-service-account@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants