fix(ci): rewrite nginx backend on the included config, not the wrapper#2496
Merged
fix(ci): rewrite nginx backend on the included config, not the wrapper#2496
Conversation
The sed substitution was running against default.conf, which only contains
the wrapper (worker_processes, events, http { include nginx.conf; }) and
does not contain the apify.github.io/apify-docs string — so the rewrite was
a no-op and the test step silently proxied to live prod instead of the PR's
local Docusaurus serve. Copy nginx.conf to nginx-test.conf and sed that
file, where the upstream URL actually lives.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
t-web
B4nan
approved these changes
May 5, 2026
markubra
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sedsubstitution in theStart Nginx with project configstep ran againstdefault.conf, which only contains the wrapper (worker_processes,events,http { include nginx.conf; }) — not thehttps://apify.github.io/apify-docsupstream URL, which lives innginx.conf. So the rewrite was a no-op and the header-assertions step silently proxied to live prod instead of the PR's local Docusaurus serve at port 3000.assert_header ".../sdk.md" "Content-Type" "text/markdown"failed because prod hadn't been redeployed yet.Test plan
Test / Docs buildjob passesRun header assertionsstep actually exercises the local build (e.g. break a.mdroute in a follow-up draft and confirm the test now fails)🤖 Generated with Claude Code