Skip to content

chore: prepare for reusable workflows#590

Merged
lukasmrtvy merged 6 commits intomasterfrom
chore/add-remote-deployment
May 23, 2023
Merged

chore: prepare for reusable workflows#590
lukasmrtvy merged 6 commits intomasterfrom
chore/add-remote-deployment

Conversation

@lukasmrtvy
Copy link
Copy Markdown
Member

@lukasmrtvy lukasmrtvy commented May 12, 2023

@lukasmrtvy lukasmrtvy requested a review from dragonraid May 12, 2023 13:27
@github-actions github-actions Bot added this to the 63rd sprint - Platform team milestone May 12, 2023
@github-actions github-actions Bot added the t-core-services Issues with this label are in the ownership of the core services team. label May 12, 2023
@lukasmrtvy lukasmrtvy requested review from fnesveda and mtrunkat May 12, 2023 13:27
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@lukasmrtvy lukasmrtvy added the adhoc Ad-hoc unplanned task added during the sprint. label May 12, 2023
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

Copy link
Copy Markdown
Contributor

@dragonraid dragonraid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some comments on how does this tie to apify/apify-docs-private, but looks good.

Copy link
Copy Markdown
Member

@mtrunkat mtrunkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Copy Markdown
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just use the GitHub token of the Apify Service Account rather than the one from this repo. It should have enough permissions for this.

Comment thread .github/workflows/deploy.yaml Outdated
Comment thread .github/workflows/invalidate.yaml Outdated
Comment thread .github/workflows/deploy.yaml Outdated
lukasmrtvy and others added 3 commits May 22, 2023 14:38
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
@lukasmrtvy lukasmrtvy requested a review from fnesveda May 22, 2023 12:39
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

@lukasmrtvy lukasmrtvy merged commit 84086cf into master May 23, 2023
@lukasmrtvy lukasmrtvy deleted the chore/add-remote-deployment branch May 23, 2023 07:55
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants