Skip to content

Conversation

@MQ37
Copy link
Contributor

@MQ37 MQ37 commented May 13, 2025

Allow disabling of process.on SIGINT handler to prevent max listeners warning when spawning multiple instances of ActorsMcpServer

@MQ37 MQ37 requested a review from Copilot May 13, 2025 08:10
@github-actions github-actions bot added the t-ai Issues owned by the AI team. label May 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a max listeners warning when spawning multiple instances of ActorsMcpServer by adding a new parameter to optionally disable the SIGINT handler registration.

  • Introduces a new boolean parameter in the constructor to control SIGINT handler setup.
  • Propagates the new parameter to the setupErrorHandling method.
Comments suppressed due to low confidence (1)

src/mcp/server.ts:48

  • [nitpick] Consider renaming the parameter 'setupSIGINTHandler' to 'enableSIGINTHandler' to more clearly indicate that it enables or disables the SIGINT handler registration.
constructor(options: ActorsMcpServerOptions = {}, setupSIGINTHandler = true) {

@MQ37 MQ37 requested a review from jirispilka May 13, 2025 08:14
@MQ37 MQ37 merged commit 219f8ee into master May 13, 2025
2 checks passed
@MQ37 MQ37 deleted the fix/max-listeners branch May 13, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants