fix: Use a new API to get Actor default build #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirispilka
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Actor default build retrieval logic to use the new API endpoint instead of the previous tagging fallback, and it updates the documentation and dependency version accordingly.
- Update to src/tools/build.ts to fetch build details via the new API client.
- Documentation update in src/tools/actor.ts to include the apifyToken parameter.
- Dependency version bump for apify-client in package.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tools/build.ts | Updated to use the new API endpoint for default builds |
| src/tools/actor.ts | Updated function docs to reflect the apifyToken parameter |
| package.json | Upgraded apify-client version to support the new API |
| const tag = actor.defaultRunOptions?.build || ''; | ||
| const buildId = actor.taggedBuilds?.[tag]?.buildId || ''; | ||
| const defaultBuildClient = await actorClient.defaultBuild(); | ||
| const buildDetails = await defaultBuildClient.get(); |
There was a problem hiding this comment.
[nitpick] The previous implementation logged an error when the build details were missing. Consider adding error logging here to aid troubleshooting in case the new API returns no actorDefinition.
Suggested change
| const buildDetails = await defaultBuildClient.get(); | |
| const buildDetails = await defaultBuildClient.get(); | |
| if (!buildDetails) { | |
| log.error(`Failed to fetch build details for Actor: ${actorIdOrName}. Build details not found.`); | |
| return null; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.