feat: normal Actor tools cache #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements caching for normal Actor tools to optimize repeated actor definition retrievals. The changes include a new interface for cache entries, a caching mechanism using LruCache in the Actor tools module, and updates to constants and dependencies to support the new caching behavior.
- Introduced ToolCacheEntry interface in src/types.ts.
- Added LruCache-based caching in src/tools/actor.ts to reuse tool definitions.
- Updated getActorDefinition in src/mcp/actors.ts and added new caching constants.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Added ToolCacheEntry interface to define the caching data structure. |
| src/tools/actor.ts | Implemented caching for normal Actor tools using LruCache and updated logic. |
| src/mcp/actors.ts | Revised getActorDefinition to fetch the default build via actor.defaultBuild(). |
| src/const.ts | Added TOOL_CACHE_MAX_SIZE and TOOL_CACHE_TTL_SECS constants for the cache. |
| package.json | Added dependency for @apify/datastructures to support caching functionality. |
jirispilka
requested changes
May 16, 2025
jirispilka
requested changes
May 16, 2025
Collaborator
jirispilka
left a comment
jirispilka
left a comment
There was a problem hiding this comment.
I'm sorry but it is not good at the moment.
Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>
integration test
github-actions
bot
added
the
tested
jirispilka
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.