-
Notifications
You must be signed in to change notification settings - Fork 78
fix: disable search for rental Actors #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jirispilka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
However, I would simplify the implementation and take a different approach—please see my comments.
There’s a major issue, though: What if the user has rental Actors?
We should also search for Actors the user is renting. For that, we’d need to access the database... because this server can also be run locally
If we want to support this in actors-mcp-server, we’ll need to introduce a new API.
FYI @mtrunkat
|
I discussed this with Mara. We should also return rental Actors for a particular user. However, since the Actors MCP server can be run locally without a database connection:
Later on, we can introduce an API to provide this functionality. However, I'm not sure if such an API would be needed for anything else. I'll share this in Product Insights. |
48d1fea to
415829b
Compare
|
@jirispilka @MichalKalita updated to logic, we are now passing list of users rented Actor IDs from please see #80 |
jirispilka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it is better to pass rented Actors than the mongo connection. Cool!
Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>
Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>
closes #135