Skip to content

Conversation

@MQ37
Copy link
Contributor

@MQ37 MQ37 commented Jun 13, 2025

closes #135

@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Jun 13, 2025
@MQ37 MQ37 requested review from MichalKalita and jirispilka June 13, 2025 12:36
Copy link
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

However, I would simplify the implementation and take a different approach—please see my comments.

There’s a major issue, though: What if the user has rental Actors?
We should also search for Actors the user is renting. For that, we’d need to access the database... because this server can also be run locally

If we want to support this in actors-mcp-server, we’ll need to introduce a new API.

FYI @mtrunkat

@jirispilka
Copy link
Collaborator

I discussed this with Mara. We should also return rental Actors for a particular user.

However, since the Actors MCP server can be run locally without a database connection:

  • For local deployments, we won’t return rentals at all.
  • For remote deployments, we can pass a MongoDB connection to the Actors MCP server and handle users rentals there.

Later on, we can introduce an API to provide this functionality. However, I'm not sure if such an API would be needed for anything else. I'll share this in Product Insights.

@MQ37 MQ37 marked this pull request as draft June 20, 2025 09:21
@MQ37 MQ37 force-pushed the fix/disable-search-rental-actors branch from 48d1fea to 415829b Compare June 20, 2025 10:02
@MQ37 MQ37 marked this pull request as ready for review June 20, 2025 14:14
@MQ37
Copy link
Contributor Author

MQ37 commented Jun 20, 2025

@jirispilka @MichalKalita updated to logic, we are now passing list of users rented Actor IDs from apify-mcp-server to the search store tool call and handling that here without passing any mongo connection (I don't think we should do this in open source repo and internal MongoDB structure should remain hidden). If list of rented Actors is passed we filter out all no-rented rental Actors, if not then we just filter out all rental Actors.

please see #80

@MQ37 MQ37 requested a review from jirispilka June 20, 2025 14:17
Copy link
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it is better to pass rented Actors than the mongo connection. Cool!

MQ37 and others added 3 commits June 23, 2025 08:58
Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>
Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>
@MQ37 MQ37 merged commit d7bdb9e into master Jun 23, 2025
2 checks passed
@MQ37 MQ37 deleted the fix/disable-search-rental-actors branch June 23, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable rental Actors in search (as rental Actors can't be really used via MCP)

3 participants