Skip to content

Conversation

@MichalKalita
Copy link
Contributor

@MichalKalita MichalKalita commented Jul 7, 2025

closes #155

Generic tool for calling Actors dynamically, for clients without support for the dynamic tools list.

TODO:

  • allow call only added tools
  • add to add-tools description info, "'call-actor' can be used when the added tool is not found"
  • add to this tool info "use 'add-actor' before this tool"
  • merge branch feat/fewer-tools--improve-tool-output and setup as target

@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Jul 7, 2025
@MichalKalita MichalKalita marked this pull request as ready for review July 8, 2025 08:57
@MichalKalita MichalKalita requested a review from MQ37 July 8, 2025 08:57
Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just a couple of comments. Please be sure to also add integration tests to the tests/integration/suite.ts for the call-actor tool. I would also personally move the tool to a separate file tools/call-actor.ts (but it's fine for now, we should refine the strucutre later on - there is an issue for that).

@MichalKalita MichalKalita requested a review from MQ37 July 8, 2025 13:26
@MichalKalita
Copy link
Contributor Author

Thank you, just a couple of comments. Please be sure to also add integration tests to the tests/integration/suite.ts for the call-actor tool. I would also personally move the tool to a separate file tools/call-actor.ts (but it's fine for now, we should refine the strucutre later on - there is an issue for that).

I wrote two simple tests: run them after the Actor is added to check if they work, and run them without adding an actor.

Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichalKalita MichalKalita merged commit 7d00f9d into master Jul 8, 2025
2 checks passed
@MichalKalita MichalKalita deleted the feat/call-actor-tool branch July 8, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add generic call-actor tool

2 participants