-
Notifications
You must be signed in to change notification settings - Fork 78
fix: export internals for apify-mcp-server #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jirispilka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it would be better to expose only the ActorsMcpServer class.
Otherwise, it becomes too easy to break something.
Do we really need to export all these functions?
Could we include them as part of the ActorsMcpServer class instead?
We can include the @MichalKalita what do you think? |
|
@MQ37 @jirispilka Exporting non-stable parts in I don't know if some other NPM package uses this library as a dependency. https://www.npmjs.com/package/@apify/actors-mcp-server?activeTab=dependents TLDR: I'm approving this PR |
|
Fun fact, |
jirispilka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, exporting more tools will just make things harder for us.
Once something is exposed, we shouldn’t change it, or it might break in apify-mcp.
Let's approve it and we will see.
To some degree I agree but since its marked as internal and we are building that for us only and not for the public (I mean the Merging 👍 |
Export internals used in
apify-mcp-serverrepo to prevent importing fromdist/.related to #102