-
Notifications
You must be signed in to change notification settings - Fork 78
feat: handle Apify specific input schema props #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee1bccf to
01f119b
Compare
jirispilka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like how the code was simplified, great job!
Moving things into apify-properties.ts made actor.ts and the whole structure much cleaner.
One question: do you think apify-properties.ts belongs in the tool directory?
I always thought that folder was mainly for tool specs. Maybe it could go in utils.ts (though that file can get pretty big).
Not sure what’s best, just wanted to mention it in case you have a better idea.
Thank you for review 👍 Great catch, the |
Oh, I missed the utils dir 🤦🏻 . Let's move it there, make sense |
Added helpers to inject Apify-specific schema structures for:
I believe this should be all Apify specific fields that require is to build their inner nested schemas from https://github.com/apify/apify-shared-js/blob/master/packages/input_schema/src/schema.json.
closes #182