Skip to content

Conversation

@MQ37
Copy link
Contributor

@MQ37 MQ37 commented Jul 30, 2025

Added helpers to inject Apify-specific schema structures for:

  • resourcePicker arrays
  • keyValue arrays
  • globs arrays
  • pseudoUrls arrays
  • proxy objects (additional Apify proxy fields)
  • Request list source (additional http request fields)

I believe this should be all Apify specific fields that require is to build their inner nested schemas from https://github.com/apify/apify-shared-js/blob/master/packages/input_schema/src/schema.json.

closes #182

@MQ37 MQ37 changed the title feat: Apify specific input schema props feat: handle Apify specific input schema props Jul 30, 2025
@github-actions github-actions bot added t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics. labels Jul 30, 2025
@MQ37 MQ37 force-pushed the feat/apify-input-schema-props branch from ee1bccf to 01f119b Compare July 30, 2025 11:34
@MQ37 MQ37 requested review from MichalKalita and jirispilka and removed request for MichalKalita and jirispilka July 30, 2025 11:35
@MQ37 MQ37 requested review from MichalKalita and jirispilka July 30, 2025 11:45
Copy link
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like how the code was simplified, great job!

Moving things into apify-properties.ts made actor.ts and the whole structure much cleaner.

One question: do you think apify-properties.ts belongs in the tool directory?

I always thought that folder was mainly for tool specs. Maybe it could go in utils.ts (though that file can get pretty big).

Not sure what’s best, just wanted to mention it in case you have a better idea.

@MQ37
Copy link
Contributor Author

MQ37 commented Jul 30, 2025

Really like how the code was simplified, great job!

Moving things into apify-properties.ts made actor.ts and the whole structure much cleaner.

One question: do you think apify-properties.ts belongs in the tool directory?

I always thought that folder was mainly for tool specs. Maybe it could go in utils.ts (though that file can get pretty big).

Not sure what’s best, just wanted to mention it in case you have a better idea.

Thank you for review 👍 Great catch, the apify-properties.ts definitely does not belong to tools/ dir (I think it should be only for tools). Let's move that to utils/ dir (as utils/apify-properties.ts). What yo dou think?

@jirispilka
Copy link
Collaborator

Thank you for review 👍 Great catch, the apify-properties.ts definitely does not belong to tools/ dir (I think it should be only for tools). Let's move that to utils/ dir (as utils/apify-properties.ts). What yo dou think?

Oh, I missed the utils dir 🤦🏻 . Let's move it there, make sense

@MQ37 MQ37 merged commit 820cff8 into master Jul 31, 2025
2 checks passed
@MQ37 MQ37 deleted the feat/apify-input-schema-props branch July 31, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle input_schema attributes that are specific to Apify

3 participants