feat: Add eslint from apify-core, add AGENTS.md #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-ai
MQ37
approved these changes
Dec 4, 2025
Contributor
MQ37
left a comment
MQ37
left a comment
There was a problem hiding this comment.
Cool, thank you 👍 Pre-approving but I found one major issue with the contributing buidelines and a few minor ones so please address them before merging.
| ``` | ||
|
|
||
| * **`type` vs `interface`:** | ||
| * Prefer `type` for flexibility. |
Contributor
There was a problem hiding this comment.
important: This statement conflicts with this eslint rule that actually forbids the type:
@typescript-eslint/consistent-type-definitions
Collaborator
Author
There was a problem hiding this comment.
Good point, I removed the eslint rule
jirispilka
changed the title
Co-authored-by: Jakub Kopecký <themq37@gmail.com>
…to feat/eslint-config-from-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used rules from mainly from
apify-core(I also checkedcrawlee)