Skip to content

fix: Fix crash in Actor.push_data with PPE and a strict charging limit #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

fix: Fix crash in Actor.push_data with PPE and a strict charging limit #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/apify/_actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,18 +614,20 @@ async def push_data(self, data: dict | list[dict], charged_event_name: str | Non
else None
)

# Push as many items as we can charge for
pushed_items_count = min(max_charged_count, len(data)) if max_charged_count is not None else len(data)

dataset = await self.open_dataset()

if max_charged_count is not None and len(data) > max_charged_count:
# Push as many items as we can charge for
await dataset.push_data(data[:max_charged_count])
else:
if pushed_items_count < len(data):
await dataset.push_data(data[:pushed_items_count])
elif pushed_items_count > 0:
await dataset.push_data(data)

if charged_event_name:
return await self.get_charging_manager().charge(
event_name=charged_event_name,
count=min(max_charged_count, len(data)) if max_charged_count is not None else len(data),
count=pushed_items_count,
)

return None
Expand Down