fix: Eliminate race condition in _fetch_requests_from_url#796
Merged
Conversation
The previous implementation used `add_done_callback` + `asyncio.create_task` to process HTTP responses, but `asyncio.gather` only awaited the HTTP request tasks — not the callback-spawned processing tasks. This caused `created_requests` to be returned before processing completed, yielding empty or incomplete results. Refactored to gather all HTTP responses first, then process each response sequentially, ensuring all extracted URLs are collected before returning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
adhoc
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #796 +/- ##
==========================================
+ Coverage 85.46% 85.54% +0.07%
==========================================
Files 46 46
Lines 2697 2691 -6
==========================================
- Hits 2305 2302 -3
+ Misses 392 389 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
reviewed
Feb 17, 2026
Process all remote URL fetches and their response bodies in parallel using a single asyncio.gather instead of sequential processing. Refactor to use @classmethod, inline _create_request_list into open, and extract _process_remote_url as a static helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pijukatel
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fetch_requests_from_urlusedadd_done_callback+asyncio.create_taskto process HTTP responses, butasyncio.gatheronly awaited the HTTP request tasks — not the callback-spawned processing taskscreated_requeststo be returned before processing completed, yielding empty or incomplete resultsTest plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com