Skip to content

test: extend retry window for synthetic PPE event propagation#865

Merged
vdusek merged 2 commits intomasterfrom
fix/flaky-e2e-ppe-synthetic-event-retry
Apr 16, 2026
Merged

test: extend retry window for synthetic PPE event propagation#865
vdusek merged 2 commits intomasterfrom
fix/flaky-e2e-ppe-synthetic-event-retry

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented Apr 16, 2026

Summary

  • Increased retry_counter(30) to retry_counter(120) in test_actor_push_data_charges_both_events and test_actor_push_data_combined_budget_limit
  • Synthetic events like apify-default-dataset-item are computed by the platform from dataset writes asynchronously — unlike explicit charges (which hit the charge endpoint directly and reflect immediately), these take longer to propagate into charged_event_counts
  • The existing 30-second window was insufficient; 2 minutes gives the platform enough time

Failed CI run that triggered this fix:

🤖 Generated with Claude Code

Synthetic events like `apify-default-dataset-item` are computed by the
platform from dataset writes asynchronously, so they propagate more
slowly than explicit charges. Increase retry_counter from 30 to 120 (2 minutes).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Apr 16, 2026
@vdusek vdusek self-assigned this Apr 16, 2026
@vdusek vdusek requested a review from Pijukatel April 16, 2026 12:24
@github-actions github-actions bot added this to the 138th sprint - Tooling team milestone Apr 16, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (390ccaf) to head (21c6515).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   86.57%   86.64%   +0.06%     
==========================================
  Files          48       48              
  Lines        2920     2920              
==========================================
+ Hits         2528     2530       +2     
+ Misses        392      390       -2     
Flag Coverage Δ
e2e 37.87% <ø> (ø)
integration 59.28% <ø> (ø)
unit 74.69% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread tests/e2e/test_actor_charge.py Outdated
Comment thread tests/e2e/test_actor_charge.py Outdated
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vdusek vdusek merged commit 87da1c2 into master Apr 16, 2026
29 checks passed
@vdusek vdusek deleted the fix/flaky-e2e-ppe-synthetic-event-retry branch April 16, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants