test: fix flaky webhook E2E test#930
Closed
vdusek wants to merge 1 commit into
Closed
Conversation
The client Actor exited milliseconds after registering the ad-hoc webhook, so the platform could process the run-succeeded event before the webhook propagated, leaving the server Actor waiting until it timed out. Keep the client run alive briefly after add_webhook to close the race window.
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 86.94% 86.94%
=======================================
Files 48 48
Lines 2942 2942
=======================================
Hits 2558 2558
Misses 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Superseded by #920, which includes this fix as part of consolidating the test polling helpers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_actor_adds_webhook_and_receives_eventoccasionally fails with the server Actor endingTIMED-OUTinstead ofSUCCEEDED(e.g. this CI run).ACTOR_RUN_SUCCEEDEDwebhook, so the platform can process the run-succeeded event before the webhook has propagated — the webhook then never fires and the server Actor blocks inhandle_request()until its 600 s run timeout.Actor.add_webhook()to close the race window.