Skip to content

Conversation

@barjin
Copy link
Member

@barjin barjin commented Nov 18, 2025

Uses synchronous require imports where available to improve compatibility with older Node versions and test frameworks.

See failing Jest test in Node 16 and Node 18.

@barjin barjin requested review from B4nan and vladfrangu November 18, 2025 11:21
@barjin barjin self-assigned this Nov 18, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 18, 2025
@github-actions github-actions bot added this to the 128th sprint - Tooling team milestone Nov 18, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 18, 2025
@barjin barjin changed the title Fix/require subtle crypto in node fix: dynamic require imports for crypto package in HMAC signature function Nov 18, 2025
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the bundle please, to make sure the compiler won't mess wity the logic

@barjin barjin merged commit 1c55aa5 into master Nov 18, 2025
9 checks passed
@barjin barjin deleted the fix/require-subtle-crypto-in-node branch November 18, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants