feat(json_schemas): Add dockerContextDir and changelog to actor schema
#584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfori
added
adhoc
There was a problem hiding this comment.
Pull request overview
This PR adds two missing properties (dockerContextDir and changelog) to the actor schema definition that were documented in the official Apify documentation but missing from the JSON schema implementation.
Key changes:
- Added
dockerContextDirfield to actor schema for specifying Docker build context directory - Added
changelogfield to actor schema for specifying changelog file path - Both fields are defined as string type without default values to avoid breaking changes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/json_schemas/src/actor.schema.ts |
Added dockerContextDir and changelog string properties to the TypeScript schema definition |
packages/json_schemas/schemas/actor.schema.json |
Added dockerContextDir and changelog string properties to the JSON schema (auto-generated from TypeScript source) |
After thoroughly reviewing the changes, I found no issues with this pull request. The implementation is:
- Consistent: Both the TypeScript and JSON schema files are properly synchronized
- Correct: The new fields follow the same pattern as similar properties (
dockerfileandreadme) - Safe: No default values are added, avoiding potential breaking changes as noted in the PR description
- Complete: Both files are updated appropriately, with the JSON file being auto-generated from the TypeScript source
The changes align well with the existing schema structure and naming conventions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
tested
tobice
approved these changes
Dec 18, 2025
| "type": "string", | ||
| "default": "../Dockerfile" | ||
| }, | ||
| "dockerContextDir": { |
JJetmar
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's missing in the schema, although it's in the documentation: https://docs.apify.com/platform/actors/development/actor-definition/actor-json#reference
Reported here: https://apify.slack.com/archives/C0L33UM7Z/p1766044857082619
Note: I didn't set any
defaultlikedockerfileandreadmeproperties have, as it could be a breaking change (but it looks like in the worker the default value is not taken into account)