Merged
Conversation
github-actions
Bot
added
the
t-console
DaveHanns
commented
Mar 30, 2026
| type McpServerTools = { | ||
| required?: readonly string[]; | ||
| export type McpServerTools = { | ||
| required?: string[]; |
Contributor
Author
There was a problem hiding this comment.
We shouldn't force client to treat their own instance of the input schema as readonly.
DaveHanns
commented
Mar 30, 2026
| type McpConnectorResourceFieldDefinition<T> = CommonResourceFieldDefinition<T> & { | ||
| resourceType: 'mcpConnector'; | ||
| mcpServers: readonly McpServer[]; | ||
| mcpServers: McpServer[]; |
Contributor
Author
There was a problem hiding this comment.
We shouldn't force client to treat their own instance of the input schema as readonly.
DaveHanns
commented
Mar 30, 2026
Comment on lines
+15
to
+16
| McpServer, | ||
| McpServerTools, |
Contributor
Author
There was a problem hiding this comment.
These types will be widely used in Console BE, FE and mcp-proxy. Exporting for convenience so that they do not need to be extracted from FieldDefinition.
valekjo
approved these changes
Mar 31, 2026
mfori
approved these changes
Mar 31, 2026
JanHranicky
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.