Skip to content

fix: Fix flaky test_common_headers_and_user_agent #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pijukatel merged 2 commits into from
Feb 28, 2025
Merged

fix: Fix flaky test_common_headers_and_user_agent #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489f5ee
In header network possible values for `accept` are under two separate…
Pijukatel Feb 27, 2025
9aead65
Merge remote-tracking branch 'origin/master' into flaky-coommon-heade…
Pijukatel Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/unit/fingerprint_suite/test_header_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@
from crawlee.fingerprint_suite._types import SupportedBrowserType


def test_get_common_headers() -> None:
def test_get_common_headers(header_network: dict) -> None:
header_generator = HeaderGenerator()
headers = header_generator.get_common_headers()

assert 'Accept' in headers
assert headers['Accept'] in get_available_header_values(header_network, {'Accept', 'accept'})
assert 'Accept-Language' in headers


Expand Down
2 changes: 1 addition & 1 deletion tests/unit/http_clients/test_httpx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ async def test_common_headers_and_user_agent(httpbin: URL, header_network: dict)
response_headers = response_dict.get('headers', {})

assert 'Accept' in response_headers
assert response_headers['Accept'] in get_available_header_values(header_network, 'Accept')
assert response_headers['Accept'] in get_available_header_values(header_network, {'Accept', 'accept'})

assert 'Accept-Language' in response_headers
assert response_headers['Accept-Language'] == COMMON_ACCEPT_LANGUAGE
Expand Down
Loading