Skip to content

fix: Fix same-domain strategy ignoring public suffix #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

fix: Fix same-domain strategy ignoring public suffix #1572

merged 1 commit into from
Nov 19, 2025
+6 −5

Conversation

@Pijukatel
Copy link
Collaborator

@Pijukatel Pijukatel commented Nov 18, 2025 •
edited by vdusek
Loading

Description

  • Use top_domain_under_public_suffix instead of just domain when comparing domains in same-domain strategy.

Issues

Testing

  • Added unit test

Checklist

  • CI passed

@github-actions github-actions bot added this to the 128th sprint - Tooling team milestone Nov 18, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Nov 18, 2025
@Pijukatel Pijukatel requested review from Mantisus and vdusek November 18, 2025 16:29
@Pijukatel Pijukatel marked this pull request as ready for review November 19, 2025 08:16
vdusek
vdusek approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel Pijukatel merged commit 3d018b2 into master Nov 19, 2025
44 of 46 checks passed
@Pijukatel Pijukatel deleted the fix-same-domain branch November 19, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

@Mantisus Mantisus Awaiting requested review from Mantisus

Assignees

@Pijukatel Pijukatel

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

128th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

Using extract_links with strategy "same-domain" extract links for different domain

3 participants

@Pijukatel @vdusek