Skip to content

fix: Fix same-domain strategy ignoring public suffix #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+6 −5
Merged

fix: Fix same-domain strategy ignoring public suffix #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/crawlee/crawlers/_basic/_basic_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,8 +1043,8 @@ def _check_enqueue_strategy(
return target_url.hostname == origin_url.hostname

if strategy == 'same-domain':
origin_domain = self._tld_extractor.extract_str(origin_url.hostname).domain
target_domain = self._tld_extractor.extract_str(target_url.hostname).domain
origin_domain = self._tld_extractor.extract_str(origin_url.hostname).top_domain_under_public_suffix
target_domain = self._tld_extractor.extract_str(target_url.hostname).top_domain_under_public_suffix
return origin_domain == target_domain

if strategy == 'same-origin':
Expand Down
7 changes: 4 additions & 3 deletions tests/unit/crawlers/_basic/test_basic_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ class AddRequestsTestInput:
'https://blog.someplace.com/index.html',
'https://redirect.someplace.com',
'https://other.place.com/index.html',
'https://someplace.jp/',
)

INCLUDE_TEST_URLS = (
Expand Down Expand Up @@ -401,7 +402,7 @@ class AddRequestsTestInput:
AddRequestsTestInput(
start_url=STRATEGY_TEST_URLS[0],
loaded_url=STRATEGY_TEST_URLS[0],
requests=STRATEGY_TEST_URLS[:4],
requests=STRATEGY_TEST_URLS,
kwargs=EnqueueLinksKwargs(strategy='same-domain'),
expected_urls=STRATEGY_TEST_URLS[1:4],
),
Expand All @@ -411,7 +412,7 @@ class AddRequestsTestInput:
AddRequestsTestInput(
start_url=STRATEGY_TEST_URLS[0],
loaded_url=STRATEGY_TEST_URLS[0],
requests=STRATEGY_TEST_URLS[:4],
requests=STRATEGY_TEST_URLS,
kwargs=EnqueueLinksKwargs(strategy='same-hostname'),
expected_urls=[STRATEGY_TEST_URLS[1]],
),
Expand All @@ -421,7 +422,7 @@ class AddRequestsTestInput:
AddRequestsTestInput(
start_url=STRATEGY_TEST_URLS[0],
loaded_url=STRATEGY_TEST_URLS[0],
requests=STRATEGY_TEST_URLS[:4],
requests=STRATEGY_TEST_URLS,
kwargs=EnqueueLinksKwargs(strategy='same-origin'),
expected_urls=[],
),
Expand Down