fix(redis): Do not remove handled request data from request queue#1787
Merged
vdusek merged 3 commits intoapify:masterfrom Mar 12, 2026
Merged
fix(redis): Do not remove handled request data from request queue#1787vdusek merged 3 commits intoapify:masterfrom
vdusek merged 3 commits intoapify:masterfrom
Conversation
kozlice
changed the title
Contributor
Author
|
Looks like an unrelated test got stuck and failed. |
vdusek
reviewed
Mar 12, 2026
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Nice! Just a note regarding the testing...
vdusek
approved these changes
Mar 12, 2026
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unlike FS and SQL storages that keep handled requests data, Redis removes it.
Issues
?
Testing
A dedicated unit test added.
Manual testing: using RedisQueueClient, enqueue a page, run crawler, check if
:datakey holds request info.Checklist