Skip to content

ci: add explicit permissions to GitHub Actions workflows#1792

Merged
vdusek merged 1 commit intomasterfrom
ci/add-explicit-permissions-to-workflows
Mar 13, 2026
Merged

ci: add explicit permissions to GitHub Actions workflows#1792
vdusek merged 1 commit intomasterfrom
ci/add-explicit-permissions-to-workflows

Conversation

@vdusek
Copy link
Collaborator

@vdusek vdusek commented Mar 13, 2026

Summary

  • Adds explicit permissions blocks to all 9 workflow files (addressing all CodeQL "Workflow does not contain permissions" security alerts).
  • Follows the principle of least privilege: contents: read as the default, with elevated permissions only on jobs that need write access (releases, changelog updates, docs deployment).
  • Pre-existing permissions on pypi_publish and _release_docs.yaml jobs are preserved.
  • Same as ci: add explicit permissions to GitHub Actions workflows apify-client-python#614.

Test plan

  • Verify CI passes on this PR (code checks, tests, doc checks)
  • Verify release workflows still work correctly (can be validated on next release)
  • Confirm CodeQL alerts are resolved after the next run of CodeQL checks

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Mar 13, 2026
@vdusek vdusek self-assigned this Mar 13, 2026
@github-actions github-actions bot added this to the 136th sprint - Tooling team milestone Mar 13, 2026
@vdusek vdusek requested a review from Pijukatel March 13, 2026 08:22
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (2175c12) to head (0c9a9f7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1792   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         156      156           
  Lines       10741    10741           
=======================================
+ Hits         9900     9901    +1     
+ Misses        841      840    -1     
Flag Coverage Δ
unit 92.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vdusek added a commit to apify/apify-sdk-python that referenced this pull request Mar 13, 2026
## Summary

- Adds explicit `permissions` blocks to all 8 workflow files, addressing
CodeQL "Workflow does not contain permissions" security alerts
- Follows the principle of least privilege: `contents: read` as the
default, with elevated permissions only on jobs that need write access
(releases, changelog updates, docs deployment)
- Pre-existing permissions on `pypi_publish` and `_release_docs.yaml`
jobs are preserved
- Same as apify/apify-client-python#614 and apify/crawlee-python#1792

---

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@vdusek vdusek merged commit 687cc12 into master Mar 13, 2026
32 checks passed
@vdusek vdusek deleted the ci/add-explicit-permissions-to-workflows branch March 13, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants