test: fix flaky Windows CI timeouts in browser tests#1806
Merged
Conversation
Increase request_handler_timeout from 1s to 10s so the static pipeline has enough time to reach the handler on slow Windows CI before the timeout fires. Replace calibrated asyncio.sleep with asyncio.Event().wait() to block indefinitely instead of relying on a sleep > timeout duration. Name the mocks for easier debugging if the test fails again. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
added
t-tooling
github-actions
bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1806 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 157 157
Lines 10848 10848
=======================================
Hits 10005 10005
Misses 843 843
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The default 15s operation_timeout is not enough for Firefox's launch_persistent_context on busy Windows CI runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
changed the title
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.sleepwithasyncio.Event().wait()in adaptive playwright timeout test and increase timeout from 1s to 10s.operation_timeoutfrom 15s to 60s in browser pool test.