ci: Grant checks: read to remaining reusable-workflow callers#1915
Merged
Conversation
Every job that calls `manual_release_docs.yaml` or `manual_version_docs.yaml` must explicitly grant `checks: read`, since reusable workflows are capped at the permissions the caller declares. Covers the doc release in the beta flow and both docs jobs in the stable release flow.
vdusek
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1915 +/- ##
==========================================
- Coverage 92.88% 92.87% -0.02%
==========================================
Files 167 167
Lines 11714 11714
==========================================
- Hits 10881 10879 -2
- Misses 833 835 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
added a commit
to apify/apify-client-python
that referenced
this pull request
May 26, 2026
## Summary Ports the CI consolidation and `wait-for-checks` adoption from `crawlee-python` to `apify-client-python`. See [apify/crawlee-python#1913](apify/crawlee-python#1913) for the original rationale and PR description; the follow-up permission fixes from [#1914](apify/crawlee-python#1914) and [#1915](apify/crawlee-python#1915) are baked in here. Two commits: 1. **Consolidate check workflows into a single Checks workflow** — merges `_check_code.yaml`, `_check_docs.yaml`, `_check_docstrings.yaml`, `_check_package.yaml`, and `_tests.yaml` into a single `_checks.yaml`. Every check now carries the shared `Checks /` prefix. `unit_tests` and `integration_tests` are gated on a `run_tests` input so `on_master.yaml` can keep skipping tests for docs-only commits. 2. **Gate manual release workflows on wait-for-checks** — replaces the inline `code_checks` step in `manual_release_stable.yaml` / `manual_release_beta.yaml` / `manual_release_docs.yaml` / `manual_version_docs.yaml` with an `apify/actions/wait-for-checks@v1.2.0` step that verifies the `Checks` workflow already passed on the dispatch commit (it runs via `on_master.yaml` on every push). Every reusable-workflow caller that ends up requesting `checks: read` (docs jobs in `on_master.yaml`, `version_docs` / `doc_release` in `manual_release_stable.yaml`, `doc_release_post_publish` in `manual_release_beta.yaml`) explicitly grants the permission, since reusable workflows are capped at the caller's permission set.
vdusek
added a commit
to apify/apify-shared-python
that referenced
this pull request
May 26, 2026
## Summary Ports the CI consolidation and `wait-for-checks` adoption from `crawlee-python` to `apify-shared-python`. See [apify/crawlee-python#1913](apify/crawlee-python#1913) for the original rationale and PR description; the follow-up permission fixes from [#1914](apify/crawlee-python#1914) and [#1915](apify/crawlee-python#1915) are referenced for completeness (this repo has no docs workflows so no extra permission grants are needed). Two commits: 1. **Consolidate check workflows into a single Checks workflow** — merges `_check_code.yaml`, `_check_package.yaml`, and `_tests.yaml` into a single `_checks.yaml`. Every check now carries the shared `Checks /` prefix. `unit_tests` is gated on a `run_tests` input so `on_master.yaml` can keep skipping tests for `ci`/`docs` commits. 2. **Gate manual release workflows on wait-for-checks** — replaces the inline `code_checks` / `tests` jobs in `manual_release_stable.yaml` and `manual_release_beta.yaml` with an `apify/actions/wait-for-checks@v1.2.0` step that verifies the `Checks` workflow already passed on the dispatch commit (it runs via `on_master.yaml` on every push).
vdusek
added a commit
to apify/apify-sdk-python
that referenced
this pull request
May 26, 2026
## Summary Ports the CI consolidation and `wait-for-checks` adoption from `crawlee-python` to `apify-sdk-python`. See [apify/crawlee-python#1913](apify/crawlee-python#1913) for the original rationale and PR description; the follow-up permission fixes from [#1914](apify/crawlee-python#1914) and [#1915](apify/crawlee-python#1915) are baked in here. Two commits: 1. **Consolidate check workflows into a single Checks workflow** — merges `_check_code.yaml`, `_check_docs.yaml`, `_check_package.yaml`, and `_tests.yaml` into a single `_checks.yaml`. Every check now carries the shared `Checks /` prefix. `unit_tests`, `integration_tests`, and `e2e_tests` are gated on a `run_tests` input so `on_master.yaml` can keep skipping tests for docs-only commits. 2. **Gate manual release workflows on wait-for-checks** — replaces the inline `code_checks` step in `manual_release_stable.yaml` / `manual_release_beta.yaml` / `manual_release_docs.yaml` / `manual_version_docs.yaml` with an `apify/actions/wait-for-checks@v1.2.0` step that verifies the `Checks` workflow already passed on the dispatch commit (it runs via `on_master.yaml` on every push). Every reusable-workflow caller that ends up requesting `checks: read` (docs jobs in `on_master.yaml`, `version_docs` / `doc_release` in `manual_release_stable.yaml`, `doc_release_post_publish` in `manual_release_beta.yaml`) explicitly grants the permission, since reusable workflows are capped at the caller's permission set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same kind of permission error as #1914, but in the remaining callers — trying to dispatch the beta release surfaced this on
manual_release_beta.yaml:A reusable workflow is capped at the permissions the calling job declares. Both
manual_release_docs.yamlandmanual_version_docs.yamlrequestchecks: readfor their (conditional) wait-for-checks step, so every caller must grant it. This PR addschecks: readto the three remaining callers:manual_release_beta.yaml→doc_release_post_publishmanual_release_stable.yaml→version_docsmanual_release_stable.yaml→doc_releaseI audited the rest:
_checks.yamlonly needscontents: read(the default), so its callers inon_master.yamlandon_pull_request.yamlare fine.