Skip to content

test: Bump goto timeout in flaky test_resource_management#1916

Merged
vdusek merged 1 commit into
masterfrom
test/fix-flaky-browser-pool-resource-management
May 26, 2026
Merged

test: Bump goto timeout in flaky test_resource_management#1916
vdusek merged 1 commit into
masterfrom
test/fix-flaky-browser-pool-resource-management

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 26, 2026

Summary

  • tests/unit/browsers/test_browser_pool.py::test_resource_management has been failing intermittently on windows-latest + Python 3.14 with playwright._impl._errors.TimeoutError: Page.goto: Timeout 30000ms exceeded.
  • Root cause: Playwright's default 30s navigation timeout is too short for a cold Windows + 3.14 CI runner; the local test server is fine, but Chromium's page load (waiting for load) overruns the default budget.
  • Fix: Pass an explicit timeout=60_000 to the single page.goto(...) call in this test.

Failure run for reference: https://github.com/apify/crawlee-python/actions/runs/26436864359/job/77821574408

The default 30s Playwright navigation timeout is too short on cold
Windows + Python 3.14 CI runners, causing intermittent failures.
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 26, 2026
@vdusek vdusek self-assigned this May 26, 2026
@vdusek vdusek requested a review from Mantisus May 26, 2026 07:01
@github-actions github-actions Bot added this to the 141st sprint - Tooling team milestone May 26, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label May 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (8d902c9) to head (22b627c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
+ Coverage   92.88%   92.89%   +0.01%     
==========================================
  Files         167      167              
  Lines       11714    11714              
==========================================
+ Hits        10880    10882       +2     
+ Misses        834      832       -2     
Flag Coverage Δ
unit 92.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vdusek vdusek merged commit 12ef1cb into master May 26, 2026
33 checks passed
@vdusek vdusek deleted the test/fix-flaky-browser-pool-resource-management branch May 26, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants