fix(memory-storage): Avoid duplicate processed requests in memory request queue client#1941
Merged
Merged
Conversation
The 'already present but not yet handled' branch in MemoryRequestQueueClient.add_batch_of_requests appended a ProcessedRequest and then fell through to the unconditional append, producing two identical entries for one input request. Remove the inner append so each input yields exactly one entry, matching the file system client.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
+ Coverage 92.85% 92.89% +0.04%
==========================================
Files 167 167
Lines 11714 11713 -1
==========================================
+ Hits 10877 10881 +4
+ Misses 837 832 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janbuchar
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MemoryRequestQueueClient.add_batch_of_requestsappended aProcessedRequesttwice for requests that were already present in the queue but not yet handled — once in thewas_already_presentbranch and again at the unconditional append after the if/else block, which that branch did not skip.AddRequestsResponse.processed_requestscontains exactly one entry per input request and inflated results for any caller iterating the list.