chore: delete comment about improving error handling in Dataset#672
Merged
vdusek merged 1 commit intoapify:masterfrom Nov 11, 2024
Merged
chore: delete comment about improving error handling in Dataset#672vdusek merged 1 commit intoapify:masterfrom
vdusek merged 1 commit intoapify:masterfrom
Conversation
vdusek
approved these changes
Nov 11, 2024
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
LGTM
(Btw. you do not have to close the issue manually, it will get closed once the PR is merged when you link it to it.)
Collaborator
I'd go a step further and say that it's not advisable to close them manually if there's a PR that resolves the issue 🙂 |
vdusek
changed the title
vdusek
added
the
t-tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deleted TODO comment.
Since handle on exceeding string length used in TS implementation is not relevant for Python because there is no maximum string length
Issues
Dataset._get_data_internal()#455