Skip to content

chore: remove npm lockfile#771

Merged
barjin merged 2 commits intomasterfrom
chore/remove-npm-lockfile
Dec 2, 2024
Merged

chore: remove npm lockfile#771
barjin merged 2 commits intomasterfrom
chore/remove-npm-lockfile

Conversation

@barjin
Copy link
Copy Markdown
Member

@barjin barjin commented Dec 2, 2024

Removes npm's package-lock.json file in favor of yarn.lock. All the documentation tooling in CI/CD uses yarn exclusively, and so should all the maintainers. Mixing package managers can cause inconsistencies in dependency resolution and is better avoided.

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 2, 2024
@barjin barjin requested a review from vdusek December 2, 2024 13:25
@barjin barjin self-assigned this Dec 2, 2024
@github-actions github-actions Bot added this to the 104th sprint - Tooling team milestone Dec 2, 2024
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 2, 2024
@barjin barjin merged commit a1cd757 into master Dec 2, 2024
@barjin barjin deleted the chore/remove-npm-lockfile branch December 2, 2024 13:34
Mantisus pushed a commit to Mantisus/crawlee-python that referenced this pull request Dec 10, 2024
Removes `npm`'s `package-lock.json` file in favor of `yarn.lock`. All
the documentation tooling in CI/CD uses yarn exclusively, and so should
all the maintainers. Mixing package managers can cause inconsistencies
in dependency resolution and is better avoided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant