feat(router): allow inline router definition

[Strajk]

As mentioned in discussion #1873

Crawlee is so good that router definition often can be straightforward, so it would be nice to have the option to define it "inline".
It also could be great for tutorials and snippets in docs.

const crawler = new CheerioCrawler({
  requestHandler: createCheerioRouter({
    [LABEL.INDEX]: async ({ enqueueLinks }) => {
      await enqueueLinks({
        selector: `#sitemap a`,
        label: LABEL.PRODUCTS,
      })
    },
    [LABEL.PRODUCTS]: async ({ $ }) => {
      await Actor.pushData({ title: $(`title`).text() })
    },
  }),
})
await crawler.run([{ url: `https://example.com`, label: LABEL.INDEX }])

I will add tests after agreeing that the "signature" is ok :)

I've used this wildcard to find&edit all crawlers, so hopefully I've changed all of them

[Strajk]

don't have strong options about this type name, feel free to suggest better

[B4nan]

those changes should go to the core package, to the router.ts file i guess. the types package is here mainly to define the storage client interface (that must be adhered in apify-client/storage-local/memory-storage clients), and a place for utility types - but this is router specific, no reason to define it elsewhere i guess

i dont mind the name (i cant find any better right now, and its not a big deal i guess)

[Strajk]

Good point, moving...
GetUserDataFromRequest is already defined there

[B4nan]

looking good, lets just move the types directly to router.ts

[B4nan]

those changes should go to the core package, to the router.ts file i guess. the types package is here mainly to define the storage client interface (that must be adhered in apify-client/storage-local/memory-storage clients), and a place for utility types - but this is router specific, no reason to define it elsewhere i guess

i dont mind the name (i cant find any better right now, and its not a big deal i guess)

[B4nan]

same for the other places

Suggested change

	UserData extends Dictionary = GetUserDataFromRequest<Context['request']>
	UserData extends Dictionary = GetUserDataFromRequest<Context['request']>,

[B4nan]

i would keep it on one line here

Suggested change

	>(
	routes?: RouterRoutes<Context, UserData>,
	): RouterHandler<Context> {
	>(routes?: RouterRoutes<Context, UserData>): RouterHandler<Context> {

[B4nan]

:]

Suggested change

	UserData extends Dictionary = GetUserDataFromRequest<Context['request']> // quick&dirty copy-paste
	UserData extends Dictionary = GetUserDataFromRequest<Context['request']>,

[Strajk]

@B4nan comments resolved (in IDE, not it web UI), thx for them!

• added basic test

not sure if and where to add it to docs ¯_(ツ)_/¯ it could be our little secret :D

[Strajk]

i'm glad that I've added the tests cause it taught me about .use middleware and it was exactly what I needed for my project :D

[B4nan]

We should have a routing guide I guess, for now, let's add at least something to the Router class jsdoc:

https://crawlee.dev/api/core/class/Router

I see the middleware example is not rendered correctly...

[Strajk]

@B4nan added docs and fixed the middleware code issue

[B4nan]

Perfect, thanks! Let's just wait for the green CI, looking good to me.

[Strajk]