feat: Add a counter of in-flight rendering type detections#3355
Merged
feat: Add a counter of in-flight rendering type detections#3355
Conversation
janbuchar
added
adhoc
barjin
approved these changes
Jan 20, 2026
Member
barjin
left a comment
barjin
left a comment
There was a problem hiding this comment.
lgtm code-wise 👍
also, what is this for?
Contributor
Author
Right, sorry. Updated the PR description. |
B4nan
approved these changes
Jan 20, 2026
Member
B4nan
left a comment
B4nan
left a comment
There was a problem hiding this comment.
the _runRequestHandler is getting pretty huge, likely worth splitting to more pieces, but we dont need to deal with that here
Contributor
Author
Oh yeah. It'll be a bit better in v4 I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.