-
Notifications
You must be signed in to change notification settings - Fork 31
Closed
Labels
t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.
Description
Currently, passing timeout=None to Client.request() / AsyncClient.request() falls back to the client-level default (30s) because the Rust side skips client_request.timeout() when the value is None:
// impit.rs:443-444
if let Some(timeout) = timeout {
client_request = client_request.timeout(timeout);
}HTTPX treats timeout=None as "no timeout" (wait indefinitely). Since impit's Python API aims to follow HTTPX conventions, it would be good to match this behavior.
Proposed: When timeout=None is passed per-request, actively disable the timeout instead of falling back to the client default.
Reactions are currently unavailable
Metadata
Metadata
Labels
t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.