Skip to content

fix: fallback to HTTP/2 on HTTP3 DNS error#255

Merged
barjin merged 2 commits intomasterfrom
fix/http3-dns-error-no-panic
Sep 2, 2025
Merged

fix: fallback to HTTP/2 on HTTP3 DNS error#255
barjin merged 2 commits intomasterfrom
fix/http3-dns-error-no-panic

Conversation

@barjin
Copy link
Member

@barjin barjin commented Sep 2, 2025

Makes DNS client in HTTP/3 record resolution optional. If the initial connection fails with Error, impit will return false for every call to host_supports_h3 (unless, e.g. alt-svc header has been registered for this domain).

@barjin barjin requested a review from Copilot September 2, 2025 09:41
@barjin barjin self-assigned this Sep 2, 2025
@github-actions github-actions bot added this to the 122nd sprint - Tooling team milestone Sep 2, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds error handling for DNS client initialization in HTTP/3 record resolution, allowing the system to gracefully fallback to HTTP/2 when DNS errors occur.

  • Makes DNS client optional in the H3Engine struct to handle initialization failures
  • Adds graceful error handling when DNS client creation fails
  • Modifies host_supports_h3 to return false when DNS client is unavailable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Sep 2, 2025
@barjin barjin merged commit bb6beb9 into master Sep 2, 2025
46 of 47 checks passed
@barjin barjin deleted the fix/http3-dns-error-no-panic branch September 2, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant