fix: keep content-length header in compressed responses#395
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #388 where Node.js binding responses were missing the content-length header for compressed responses, by updating dependencies and adding a regression test to ensure the header is preserved.
Changes:
- Add a Node integration test asserting
content-lengthis present alongsidecontent-encoding. - Update the Node native binding loader’s expected package version to
0.9.2. - Patch Rust dependency resolution to use an Apify fork of
tower-http(affectingreqwest’s dependency graph) and updateCargo.lockaccordingly.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
impit-node/test/basics.test.ts |
Adds a regression test for content-length on compressed responses. |
impit-node/index.js |
Bumps the native binding package version check from 0.9.0 to 0.9.2. |
Cargo.toml |
Patches tower-http to an Apify git source (currently tracking main). |
Cargo.lock |
Locks tower-http to the selected git commit and updates transitive deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #388