Skip to content

fix(ci): sync yarn.lock and index.js to git after npm release#400

Merged
barjin merged 2 commits intomasterfrom
copilot/fix-npm-files-sync-issue
Mar 4, 2026
Merged

fix(ci): sync yarn.lock and index.js to git after npm release#400
barjin merged 2 commits intomasterfrom
copilot/fix-npm-files-sync-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 4, 2026

After a release, napi version updates the optional dependency versions in package.json and regenerates index.js, but yarn.lock is never updated to match — causing the next CI run to fail with a lockfile mismatch.

Changes

  • node-release.yaml: Add yarn install --no-immutable after npm publish (so the new platform packages are resolvable in the registry) and before the commit step, so yarn.lock is refreshed and committed to git alongside the updated package.json and index.js.
Original prompt

This section details on the original issue you should resolve

<issue_title>CI: automatic release doesn't update npm files</issue_title>
<issue_description>After running an automatic CI release to npm, impit-node won't install in the subsequent CI run, as the package.json and yarn.lock files are not synchronized. We should push the lockfile (as well as the generated changes in index.js) to git on release to prevent this.</issue_description>

<agent_instructions>Fix this, make minimal changes to achieve the goal. use conventional commits for commit messages and PR titles. do not add excessive comments.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: barjin <61918049+barjin@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI to update npm files automatically on release fix(ci): sync yarn.lock and index.js to git after npm release Mar 4, 2026
@github-actions github-actions bot added this to the 135th sprint - Tooling team milestone Mar 4, 2026
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 4, 2026
@barjin barjin marked this pull request as ready for review March 4, 2026 13:32
Copy link
Copy Markdown
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging even with failing CI, the lockfile is regenerated (and therefore CI unblocked) in #398, which will follow soon.

@barjin barjin merged commit abe53e3 into master Mar 4, 2026
6 of 7 checks passed
@barjin barjin deleted the copilot/fix-npm-files-sync-issue branch March 4, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: automatic release doesn't update npm files

3 participants