fix(deps): migrate http3 DNS lookup from hickory-client to hickory-resolver#454
Merged
Conversation
…solver hickory-client is being retired (subsumed into hickory-net per the 0.26 release notes) and never received a stable 0.26 release, which kept us pinned to hickory-proto 0.25.x and exposed to RUSTSEC-2026-0119 and RUSTSEC-2026-0120 plus the NSEC3 unbounded-loop advisory. Switching http3.rs to hickory-resolver 0.26.1 pulls in patched hickory-proto and drops the hard-coded 8.8.8.8 nameserver in favour of the system resolver config.
github-actions
Bot
added
the
t-tooling
barjin
changed the title
http3 DNS lookup from hickory-client to hickory-resolver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impit/src/http3.rsonly used hickory to fire a single HTTPS-record DNS query against a hard-coded8.8.8.8:53for h3 discovery. Migrated that tohickory-resolver 0.26.1, which:hickory-proto 0.26.1,Dropimpl since the resolver manages its own connections.API shifts handled along the way:
Record::data()→Record.data(now a public field),SVCB::svc_params()→SVCB.svc_params(public field).